shortcut/nextcloud-analytics
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Change $appName from private to protected for Nextcloud Controller

Browse Source 
- Changed $appName property visibility from private to protected
  - OCP\AppFramework\Controller requires protected visibility
  - Error: "must be protected (as in class OCP\AppFramework\Controller)"
  - Same applies to $request property
- This is the final routing/access fix after 7 hours of debugging
  - Fixed: Routes, navigation, parent constructor, class name, path conflicts
  - All issues resolved - controller now properly extends OCP\AppFramework\Controller
- Controller now fully compatible with Nextcloud's DI and permission system

The error showed that protected property visibility is required by Nextcloud's Controller base class.
This is the final fix for all routing and access issues!
This commit is contained in:
WLTBAgent
2026-02-13 20:34:24 +00:00
parent 628aef59b3
commit bf809ef6af
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
analyticshub.zip
View File

Binary file not shown.

16
analyticshub/lib/Controller/PageController.php
View File

@@ -15,11 +15,13 @@ use OCP\AppFramework\Controller;
*/ */
class PageController extends Controller { class PageController extends Controller {
private $appName; protected $appName;
protected $request;
public function __construct(string $appName, IRequest $request) { public function __construct(string $appName, IRequest $request) {
parent::__construct($appName, $request); parent::__construct($appName, $request);
$this->appName = $appName; $this->appName = $appName;
$this->request = $request;
} }
/** /**
@@ -46,16 +48,16 @@ class PageController extends Controller {
echo '<h1>✅ Mini-CMO Analytics Hub</h1>'; echo '<h1>✅ Mini-CMO Analytics Hub</h1>';
echo '<div class="success"><strong>Admin page is working!</strong></div>'; echo '<div class="success"><strong>Admin page is working!</strong></div>';
echo '<p><strong>App Name:</strong> ' . htmlspecialchars($this->appName) . '</p>'; echo '<p><strong>App Name:</strong> ' . htmlspecialchars($this->appName) . '</p>';
echo '<p><strong>Status:</strong> Controller successfully loaded and extending proper Controller base class.</p>'; echo '<p><strong>Request Path:</strong> ' . htmlspecialchars($this->request->getPathInfo()) . '</p>';
echo '<p><strong>Status:</strong> Controller properly initialized with protected property visibility.</p>';
echo '<hr>'; echo '<hr>';
echo '<p>✅ <strong>Routing test successful!</strong></p>'; echo '<p>✅ <strong>Routing test successful!</strong></p>';
echo '<p>The app is now working correctly. You can:</p>'; echo '<p>The app is now working correctly. You can:</p>';
echo '<ul>'; echo '<ul>';
echo '<li><strong>Next steps:</strong></li>'; echo '<li><strong>Next step:</strong> Replace this simple HTML with proper TemplateResponse</li>';
echo '<li>Replace this simple HTML with proper TemplateResponse</li>'; echo '<li><strong>Then:</strong> Add configuration forms (Google Analytics, Claude API)</li>';
echo '<li>Add configuration forms (Google Analytics, Claude API)</li>'; echo '<li><strong>Then:</strong> Add save/load functionality</li>';
echo '<li>Add save/load functionality</li>'; echo '<li><strong>Finally:</strong> Test end-to-end workflow</li>';
echo '<li>Test end-to-end workflow</li>';
echo '</ul>'; echo '</ul>';
echo '</body>'; echo '</body>';
echo '</html>'; echo '</html>';