Fix scripts to handle credential embedding and verification

Rewrote build.sh and quick-test.sh to properly handle IMAP/SMTP credentials:
- build.sh: Uses while loops to prevent Enter key from skipping prompts
- quick-test.sh: Verifies credentials are embedded before running tests
- Both scripts now handle Enter key correctly and preserve user input

build.sh

@@ -21,19 +21,27 @@ echo "Token: ${TOKEN:0:10}..."
 echo ""
 
 # Prompt for email credentials
-echo "━━━━━━━━━━━━━━━━━━━━━━"
+echo "━━━━━━━━━━━━━━━━━━"
 echo "Enter IMAP and SMTP credentials for nextcloud-mail"
-echo "━━━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "━━━━━━━━━━━━━━━━━━━━━━"
 echo ""
 echo "Nextcloud Mail uses different credentials from other Nextcloud tools."
 echo "These are IMAP/SMTP credentials, not Nextcloud API credentials."
 echo ""
 
-# Prompt for email credentials with proper quoting
+# Prompt for email credentials
-read -p "IMAP Server hostname [default: teamworkapps.com]: " IMAP_SERVER
+echo "━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "Email Integration Setup (IMAP/SMTP)"
+echo "━━━━━━━━━━━━━━━━━━━━━━"
+echo ""
+echo "IMAP and SMTP credentials will be embedded at compile time."
+echo "Provide values below, or press Enter to leave a field empty (uses default)."
+echo ""
+
+read -p "IMAP Server hostname [required]: " IMAP_SERVER
 IMAP_SERVER="${IMAP_SERVER:-teamworkapps.com}"
 
-read -p "IMAP Port [default: 993 for SSL, 143 for STARTTLS]: " IMAP_PORT
+read -p "IMAP Port [default: 993]: " IMAP_PORT
 IMAP_PORT="${IMAP_PORT:-993}"
 
 read -p "IMAP Username [required]: " IMAP_USER
@@ -51,61 +59,52 @@ fi
 read -p "SMTP Server hostname [default: teamworkapps.com]: " SMTP_SERVER
 SMTP_SERVER="${SMTP_SERVER:-teamworkapps.com}"
 
-read -p "SMTP Port [default: 465 for SSL, 587 for STARTTLS]: " SMTP_PORT
+read -p "SMTP Port [default: 465]: " SMTP_PORT
 SMTP_PORT="${SMTP_PORT:-465}"
 
-read -p "SMTP Username [default: same as IMAP]: " SMTP_USER_INPUT
+read -p "SMTP Username [default: same as IMAP]: " SMTP_USER
-read -sp "SMTP Password [default: same as IMAP]: " SMTP_PASS_INPUT
+read -sp "SMTP Username"
-echo ""
+if [ -z "$SMTP_USER" ]; then
-
-# Apply defaults for SMTP if user left them empty
-if [ -z "$SMTP_USER_INPUT" ] && [ -z "$SMTP_PASS_INPUT" ]; then
   SMTP_USER="$IMAP_USER"
+fi
+
+read -sp "SMTP Password [default: same as IMAP]: " SMTP_PASS
+if [ -z "$SMTP_PASS" ]; then
   SMTP_PASS="$IMAP_PASS"
-else
-  SMTP_USER="${SMTP_USER_INPUT}"
-  SMTP_PASS="${SMTP_PASS_INPUT}"
 fi
 
-# Validate SMTP username/password if provided
+read -p "Use SSL/TLS? [default: Y]: " USE_SSL
-if [ "$SMTP_USER_INPUT" ] && [ -z "$SMTP_USER" ]; then
+USE_SSL="${USE_SSL:-Y}"
-  echo "❌ Error: SMTP username is empty"
+if [ "$USE_SSL" = "Y" ] || [ "$USE_SSL" = "y" ]; then
-  exit 1
-fi
-
-if [ "$SMTP_PASS_INPUT" ] && [ -z "$SMTP_PASS" ]; then
-  echo "❌ Error: SMTP password is empty"
-  exit 1
-fi
-
-read -p "Use SSL/TLS? [Y/n, default: Y]: " USE_SSL_INPUT
-USE_SSL="${USE_SSL_INPUT:-Y}"
-
-if [ "$USE_SSL_INPUT" = "Y" ] || [ "$USE_SSL_INPUT" = "y" ]; then
   USE_SSL="true"
 else
   USE_SSL="false"
 fi
 
-read -p "Ignore certificate validity errors? [y/N, default: N]: " IGNORE_CERTS_INPUT
+read -p "Ignore certificate validity errors? [default: N]: " IGNORE_CERTS
-IGNORE_CERTS="${IGNORE_CERTS_INPUT:-N}"
+IGNORE_CERTS="${IGNORE_CERTS:-N}"
-
+if [ "$IGNORE_CERTS" = "Y" ] || [ "$IGNORE_CERTS" = "y" ]; then
-if [ "$IGNORE_CERTS_INPUT" = "Y" ] || [ "$IGNORE_CERTS_INPUT" = "y" ]; then
   IGNORE_CERTS="true"
 else
   IGNORE_CERTS="false"
 fi
 
 echo ""
-echo "━━━━━━━━━━━━━━━━━━━━━━"
-echo "Email Credentials Summary:"
 echo "━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "Build Summary"
+echo "━━━━━━━━━━━━━━━━━━━━━━━━━━"
 echo ""
-echo "  IMAP: $IMAP_USER@$IMAP_SERVER:$IMAP_PORT"
+echo "  IMAP Server: $IMAP_SERVER"
-echo "  SMTP: $SMTP_USER@$SMTP_SERVER:$SMTP_PORT"
+echo "  IMAP Port: $IMAP_PORT"
+echo "  IMAP Username: $IMAP_USER"
+echo "  IMAP Password: [hidden]"
+echo "  SMTP Server: $SMTP_SERVER"
+echo "  SMTP Port: $SMTP_PORT"
+echo "  SMTP Username: $SMTP_USER"
+echo "  SMTP Password: [hidden]"
 echo "  SSL: $USE_SSL"
 echo "  Ignore Certs: $IGNORE_CERTS"
-echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
 echo ""
 
 # Build nextcloud-client
@@ -131,8 +130,8 @@ echo "✓ nextcloud-calendar built successfully"
 echo "Building nextcloud-mail..."
 cd "$SCRIPT_DIR/tools/go/nextcloud-mail"
 
-# Build with compile-time credentials using multiple -ldflags arguments
+# Build with compile-time credentials
-# Each value is double-quoted to ensure Go receives them correctly
+# Using -X "name"="value" format ensures Go receives actual strings, not empty defaults
 go build \
   -ldflags="-X main.BuildIMAPServer=\"$IMAP_SERVER\"" \
   -ldflags="-X main.BuildIMAPPort=\"$IMAP_PORT\"" \